Continue to improve our nokogiri support specification. #1497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [this pr](#1493) we got a quick fix to our broken builds on travis due to nokogiri 1.6.6.4 and 1.6.6.3 not working on travis. Now that nokogiri is releasing new versions, we want to continue to get them. This patch ensures we don't get the versions that don't work on travis, but does give us new versions.
| @@ -32,7 +32,7 @@ if RUBY_VERSION < '1.9.2' | |||
| elsif RUBY_VERSION < '1.9.3' | |||
| gem 'nokogiri', '1.5.2' | |||
| else | |||
| gem 'nokogiri', ['~> 1.5', '< 1.6.6.5'] | |||
| gem 'nokogiri', ['~> 1.5', '< 1.6.6.3', '> 1.6.6.4'] | |||
There was a problem hiding this comment.
My bad, this actually needs to be ['~> 1.5', '!= 1.6.6.3', '!= 1.6.6.4']
JonRowe
added a commit
that referenced
this pull request
Dec 1, 2015
Continue to improve our nokogiri support specification.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr we got a
quick fix to our broken builds on travis due to nokogiri 1.6.6.4 and
1.6.6.3 not working on travis. Now that nokogiri is releasing new
versions, we want to continue to get them. This patch ensures we don't
get the versions that don't work on travis, but does give us new
versions.