Fix Undefined Method cache on rails 4.2.5.1 / 4.1.14.1

[fcheung]

This should fix #1532

[bquorning]

The related change on Rails 4.1 (rails/rails@be543e8) and 4.2 (rails/rails@0c5c32a).

This change does indeed seem to make my spec suite run again.

[jhawthorn]

👍 This fixes ny test suite. Although perhaps we want to be calling original_path_set.find_all_anywhere instead when we are wrapping that method.

[fcheung]

I think the 1.8.7 failures are down to the rails 3-2 branch having broken 1.8.7 support. Not sure about the nokogiri install failures

[fcheung]

As far as I can see, find_all_anywhere isn't a method on PathSet - only on Resolver

[fables-tales]

Hi @fcheung can you also provide a spec for this? Let me know if you need some help with that.

[rochers]

Also affecting my application's test suite after upgraded to Rails 4.2.5.1. Let me know if you need any help.

[fcheung]

@samphippen I couldn't find any specs that cover the existing code, but the cucumber features seem to. I wrote

  Scenario: View specs can explicitly render files
    Given a file named "spec/views/widgets/widget.html.erb_spec.rb" with:
      """ruby
      require "rails_helper"

      RSpec.describe "rendering the widget template" do
        it "displays the widget" do
          assign(:widget, Widget.create!(:name => "slicer"))

          render :file => File.expand_path "widgets/widget.html.erb"

          expect(rendered).to match /slicer/
        end
      end
      """
    And a file named "app/views/widgets/widget.html.erb" with:
      """
      <h2><%= @widget.name %></h2>
      """
    When I run `rspec spec/views`
    Then the examples should all pass

But I can't get the existing testsuite to run, even before I make my changes:

export RAILS_VERSION=4.1-stable
bundle install --standalone --binstubs
./script/run_build

explodes with

/Users/fred/rspec-rails/bundle/ruby/2.3.0/bundler/gems/rails-7921ff8c21d1/activesupport/lib/active_support/test_case.rb:1:in `<top (required)>': undefined method `gem' for main:Object (NoMethodError)
    from /Users/fred/rspec-rails/bundle/ruby/2.3.0/bundler/gems/rails-7921ff8c21d1/activesupport/lib/active_support/dependencies.rb:247:in `require'
    from /Users/fred/rspec-rails/bundle/ruby/2.3.0/bundler/gems/rails-7921ff8c21d1/activesupport/lib/active_support/dependencies.rb:247:in `block in require'
    from /Users/fred/rspec-rails/bundle/ruby/2.3.0/bundler/gems/rails-7921ff8c21d1/activesupport/lib/active_support/dependencies.rb:232:in `load_dependency'
    from /Users/fred/rspec-rails/bundle/ruby/2.3.0/bundler/gems/rails-7921ff8c21d1/activesupport/lib/active_support/dependencies.rb:247:in `require'
    from /Users/fred/rspec-rails/bundle/ruby/2.3.0/bundler/gems/rails-7921ff8c21d1/actionpack/lib/action_controller/test_case.rb:428:in `<module:ActionController>'

[fcheung]

(ruby 2.3.0 on OS X)

[bquorning]

Could it be a Ruby manager issue (rvm/rbenv/chruby)? It looks like the rubygems library is not loaded.

[bquorning]

Found this:

rspec-rails/script/functions.sh

Lines 14 to 18 in 9eee11a

	# Don't allow rubygems to pollute what's loaded. Also, things boot faster
	# without the extra load time of rubygems. Only works on MRI Ruby 1.9+
	if is_mri_192_plus; then
	export RUBYOPT="--disable=gem"
	fi

[yujinakayama]

I think the 1.8.7 failures are down to the rails 3-2 branch having broken 1.8.7 support.

Yeah, it's now fixed in 3-2-stable branch though not yet released.

rails/rails#23250

[fcheung]

example feature is nonsense but I have at least got existing features running

[fcheung]

@samphippen is the feature I added any good? Fails appropriately when I revert the change to view_rendering.rb

[fables-tales]

@fcheung it's helpful! I'm not going to be able to give this my full attention until this afternoon, but @pixeltrix and I are going to push out a fix.

[fables-tales]

Closing in favour of #1535