Backport: Fix empty template rendering for Rails 4.2.5.1 #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rspec#1532. Refactor the template rendering overrides in controller specs to be more compatible with the Action View public api. Previously `EmptyTemplatePathSetDecorator` overrode the `find_all` method to wrap a path set. However `ActionView::PathSet` is not public api so instead create a subclass of `ActionView::FileSystemResolver` to return an empty template and treat `view_paths` as an array of string-like objects.
|
We don't maintain older versions of RSpec. This has been released already please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #1535
Refactor the template rendering overrides in controller specs to be more
compatible with the Action View public api. Previously
EmptyTemplatePathSetDecoratoroverrode the
find_allmethod to wrap a path set. HoweverActionView::PathSetis not public api so instead create a subclass of
ActionView::FileSystemResolverto return an empty template and treat
view_pathsas an array of string-like objects.