Fix empty view rendering

[JonRowe]

This fixes two regressions that were introduced by #1535.

Closes #1556
Closes #1551

/cc @samphippen @pixeltrix

[pixeltrix]

Doesn't this just end up adding an uninitialised EmptyTemplateResolver to the view paths array?

[JonRowe]

Yes but that's the point, the parts of this that are used are here and don't depend on initialisation.

[pixeltrix]

This bit is to fix #1551 isn't it? If so adding your custom resolver instance to the view path with result in an instance of EmptyTemplateResolver with a nil path instance variable instead. I thought the idea would be to put the custom resolver into the path without wrapping it.

[JonRowe]

We don't want a custom resolver in the path, the aim is to disable view rendering, my understanding is that would do the opposite.

[pixeltrix]

Yes, but it'd generate template missing errors because find_templates would be called on the EmptyTemplateResolver instance and not the custom resolver instance.

[JonRowe]

Well we need to find a way to pass the details of the resolver down into that implementation without loosing this subclass, alternatively we could monkey patch the instance of the resolver with the required methods but I'd rather not do that, that seems dangerous

[bquorning]

The problem is that when path is a Resolver instance, it knows how to look up templates. And the super call in this EmptyTemplateResolver#find_templates doesn’t call up to that resolver.

[bquorning]

Please see #1568 #1580 for a changed implementation that works for my spec suite.

Update: #1568 has been superseded by #1580.

[JonRowe]

Closed in prerferance to #1580