Skip to content

Don't use Rake v11 with older rubies #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Don't use Rake v11 with older rubies #1570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ end

gem 'sqlite3', '~> 1.3.6'

if RUBY_VERSION >= '1.9.3'
gem 'rake', '>= 10.0.0'
else
gem 'rake', '~> 10.0' # rake 11 requires Ruby 1.9.3 or later
end

# Capybara versions that support RSpec 3 only support RUBY_VERSION >= 1.9.3
if RUBY_VERSION >= '1.9.3'
gem 'capybara', '~> 2.2.0', :require => false
Expand Down
6 changes: 6 additions & 0 deletions example_app_generator/generate_app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@
|# Rack::Cache 1.3.0 requires Ruby >= 2.0.0
|gem 'rack-cache', '< 1.3.0' if RUBY_VERSION < '2.0.0'
|
|if RUBY_VERSION >= '1.9.3'
| gem 'rake', '>= 10.0.0'
|else
| gem 'rake', '~> 10.0' # rake 11 requires Ruby 1.9.3 or later
|end
|
|gem 'rspec-rails',
| :path => '#{rspec_rails_repo_path}',
| :groups => [:development, :test]
Expand Down
1 change: 0 additions & 1 deletion rspec-rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ Gem::Specification.new do |s|
end
end

s.add_development_dependency 'rake', '~> 10.0'
s.add_development_dependency 'cucumber', '~> 1.3.5'
s.add_development_dependency 'aruba', '~> 0.5.4'
s.add_development_dependency 'ammeter', '1.1.2'
Expand Down