Skip to content

Don't swallow exceptions for flow control. fixes #1656 #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

betesh
Copy link
Contributor

@betesh betesh commented Jul 7, 2016

See discussion on #1656

@myronmarston
Copy link
Member

LGTM.

I wonder if there are any other places where we use an exception approach that could switch to a version check approach?

@myronmarston myronmarston merged commit 7bb4e1b into rspec:master Jul 7, 2016
@betesh
Copy link
Contributor Author

betesh commented Jul 7, 2016

Can we get this released as 3.5.1? That would allow me to use it with rspec 3.5.0

@JonRowe
Copy link
Member

JonRowe commented Jul 7, 2016

I believe @myronmarston is planning a release of all the gems shortly, would you mind waiting a day or so? We like to bundle together a few fixes at a time :)

@myronmarston
Copy link
Member

I believe @myronmarston is planning a release of all the gems shortly, would you mind waiting a day or so? We like to bundle together a few fixes at a time :)

I released rspec-core 3.5.1 last night, and didn't have any more releases planned. No need to wait for this.

@JonRowe
Copy link
Member

JonRowe commented Jul 7, 2016

My mistake, I assumed we were bumping them all, I can handle the release if you'd like?

@myronmarston
Copy link
Member

There was nothing new to release in the others, and I usually release patch versions freely when needed.

I can handle the release if you'd like?

Go for it!

JonRowe pushed a commit that referenced this pull request Jul 7, 2016
Don't swallow exceptions for flow control.  fixes #1656
@JonRowe
Copy link
Member

JonRowe commented Jul 8, 2016

3.5.1 has been released

@betesh
Copy link
Contributor Author

betesh commented Jul 8, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants