Update scaffold generator to care about --api flag.

[k3rni]

• don't generate view specs
• don't generate route specs for new and edit
• generate a slightly different controller spec, without redirects but
  with JSON expectations

Addresses #1672

[k3rni]

The CI failures seem to be of two kinds:

1. https://travis-ci.org/rspec/rspec-rails/jobs/150062031 - weird unrelated failure ?
2. https://travis-ci.org/rspec/rspec-rails/jobs/150062007 - Rubocop complaints. BTW it seems that Rubocop is only enabled for rubies below 2.2, is that intentional?

How should I proceed? Do you have suggestions on what to extract out of the ScaffoldGenerator class, and how to address the weird errors?

[JonRowe]

I've bumped the broken build, you'll need to fix the rubocop failure though.

BTW it seems that Rubocop is only enabled for rubies below 2.2, is that intentional?

It's a side effect of the version we're running.

[k3rni]

Per the linked issue, the easiest way to satisfy Rubocop here would be to just drop these methods. Is it okay, if that solution were to be accepted, to do that in this PR?

[JonRowe]

If you're sure they're not used, the build should fail if they are...

[fables-tales]

@k3rni you'll need to update this for #1689 which removes assigns and assert templates from our specs. We definitely don't want those anymore. If you could do that, I can probably merge this down.

[k3rni]

Rebasing to current master and updating.

[k3rni]

I chose to test for response.location returning the newly created object's url in POST#create. This is to match testing redirect_to in regular controllers.

[fables-tales]

@k3rni

you missed moving this file name assignment up to outside of the 1.9.3 conditional, so this does not work on ruby interpreters greater than or equal to 1.9.3, can you add a spec for this case and make it pass? Thanks

[fables-tales]

@k3rni sorry about the slow review here, it's been a crazy week at work. I've left you a review note, but apart from that, I think this looks great and I'll merge it when you're done 👍 Thank you so much ✨

[k3rni]

@samphippen so basically just move the assignment (line 140 above) up outside the conditional, and verify in tests, got it.

[JonRowe]

Thanks ❤️