switch git from git to https #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM on 💚 |
JonRowe
force-pushed
the
change_git_to_https
branch
from
949cba9 to
9768d97
Compare
|
This still looks legit 2 years later. The build issue related to ammeter pulling in a version of rails that's too new doesn't make a lot of sense. Perhaps a retry after rebasing would get bundler to behave there? |
JonRowe
force-pushed
the
change_git_to_https
branch
from
9768d97 to
a4c0154
Compare
|
A rebase made this green, good digging @mikegee |
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
JonRowe
added a commit
that referenced
this pull request
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per rspec/rspec-core#2327