Update Readme #1703
Update Readme #1703
Conversation
|
|
||
| # Skip all specs that are tagged slow | ||
| bundle exec rspec spec/controllers/accounts_controller_spec.rb --tag "~slow" | ||
|
|
There was a problem hiding this comment.
This is kind of arbitrary, theres a lot of different ways to run specs and this is still only a few.
| ``` | ||
| You can find out more about rspec tags [here.](https://relishapp.com/rspec/rspec-core/v/2-3/docs/command-line/tag-option) |
There was a problem hiding this comment.
Rather than doing this (and linking to an unsupported version of the docs) can you link to the documentation about how to run different combination of specs, then you can eliminate the arbitrary examples above.
| @@ -86,6 +97,7 @@ There are three particular `rspec-rails` specific changes to be aware of: | |||
| 3. [Rails 4.x `ActiveRecord::Migration` pending migration checks](https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#pending-migration-checks) | |||
| 4. Extraction of `stub_model` and `mock_model` to | |||
| [`rspec-activemodel-mocks`](https://github.com/rspec/rspec-activemodel-mocks) | |||
| 5. In Rails 5.x, controller testing has been moved to its own gem which is [rails-controller-testing](https://github.com/rails/rails-controller-testing). So using `assings` in your controller test without adding this gem would raise an exception. | |||
There was a problem hiding this comment.
You have a typo here, assings instead of assigns and would you mind re-wording it slightly? It reads better as
Using
assignsin your controller specs without adding this gem will no longer work.
| @@ -594,4 +606,4 @@ task("spec").clear | |||
|
|
|||
| ## Feature Requests & Bugs | |||
|
|
|||
| See <http://github.com/rspec/rspec-rails/issues> | |||
| See <http://github.com/rspec/rspec-rails/issues> | |||
There was a problem hiding this comment.
Can you revert whatever this change is.
There was a problem hiding this comment.
Oops I guess that just one more line added. Will do that now
- added changes to the Upgrade Note section about Rails 5 and controller testing
|
All fix have been implemented |
|
Did you want to add the link to more detailed documenation on how to run specs? |
|
@JonRowe so the issues is that I can't point to a single article/documentation on https://www.relishapp.com that suggest how specs ar run. Since there are various ways to running specs for different versions of RSpec. In addition, I don't want to point to any article outside relishapp. |
|
Thanks |
- added changes to the Upgrade Note section about Rails 5 and controller testing
controller testing
hacktoberfest