Use keyword args for HTTP methods in controller specs only on Rails 5

[yujinakayama]

This closes #1669.

[JonRowe]

These aren't keyword arguments tho, they're keyword argument on Rails 5, but new style hash access on Rails 4, I'm still unsure why it breaks and this doesn't fix the fact that specs don't pick it up...

[yujinakayama]

Should we replace the skip in the spec with empty hash?

  let(:valid_attributes) {
-   skip("Add a hash of attributes valid for your model")
+   {}
  }

[JonRowe]

I tried that in #1680, (basically we don't want to remove them from peoples scaffolded specs, but we do want them to run in our specs) but it passes and I'm not sure it's working correctly

[yujinakayama]

It seems that the scaffold specs are not executed in cukes since they're always removed before each scenario.

rspec-rails/features/support/env.rb

Lines 37 to 44 in 2175c72

	# We want fresh `example_app` project with empty `spec` dir except helpers.
	# FileUtils.cp_r on Ruby 1.9.2 doesn't preserve permissions.
	system('cp', '-r', example_app_dir, aruba_dir)
	helpers = %w[spec/spec_helper.rb spec/rails_helper.rb]
	Dir["#{aruba_dir}/spec/*"].each do |path|
	next if helpers.any? { |helper| path.end_with?(helper) }
	FileUtils.rm_rf(path)
	end

[mrageh]

@yujinakayama and @JonRowe I think we should merge this PR, because in Rails 5 HTTP request methods use keyword args to process requests. Whereas any version below Rails 5 uses does not use keyword args. That means our scaffold generator will produce invalid controller specs.

For more context please refer to this PR.

[JonRowe]

@mrageh as per my earlier comments this shouldn't be merged, Rails 5 swapped option hashes for keyword args, the api is supposed to be compatible without any changes to the user

[JonRowe]

@mrageh However if you'd like to work on getting our generated specs being tested as part of the build I'd welcome the help in a seperate PR.

[yujinakayama]

@JonRowe

the api is supposed to be compatible without any changes to the user

No, get '/', params: {} does not work on Rails 4.2. Try the reproducible example in #1669 (comment).

[mrageh]

@JonRowe I may have missed something, but I'm fairly certain the Rails 5 api change is not backwards compatible. Can you send me some docs/github discussion anything that says otherwise?

[yujinakayama]

This should be rebased once #1680 is merged.