Improve failure message for AJ matcher #1722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Oct 11, 2016
| @@ -89,7 +96,7 @@ def supports_block_expectations? | |||
| private | |||
|
|
|||
| def check(jobs) | |||
| @matching_jobs_count = jobs.count do |job| | |||
| @matching_jobs, @unmatching_jobs = jobs.partition do |job| | |||
There was a problem hiding this comment.
Would this return jobs from another class?
There was a problem hiding this comment.
Yes, it will return all jobs that were queued during given action.
I think most of the time number of jobs should be low, so we don't need to scope only to the same class jobs.
This way it's clear for end user what's going on, and it may happen that mistake is also in job class name (like copy pasting) ;-)
| "expected to enqueue #{base_message}" | ||
| "expected to enqueue #{base_message}".tap do |msg| | ||
| if @unmatching_jobs.any? | ||
| msg << "\nUnmatched enqueued jobs:" |
There was a problem hiding this comment.
I think this would read better as "Queued jobs:"
| if @unmatching_jobs.any? | ||
| msg << "\nUnmatched enqueued jobs:" | ||
| @unmatching_jobs.each do |job| | ||
| msg << "\n* #{base_job_message(job)}" |
There was a problem hiding this comment.
We don't use a '*' elsewhere when indenting, maybe for consistency just go with 2 spaces?
|
Thanks :) |
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing unmatched jobs should help in finding failure reason.
If you have some suggestions how to improve this message, let me know.