Skip to content

Get rspec-rails running on Rails 5-0-stable #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2016
Merged

Get rspec-rails running on Rails 5-0-stable #1760

merged 2 commits into from
Dec 17, 2016

Conversation

maclover7
Copy link
Contributor

  • Added missing require
  • Change Travis CI configuration to use 5-0-stable instead of 5.0.0, since new 5.0.x versions (for example, 5.0.1) will be landing soon

cc @samphippen

@maclover7
Copy link
Contributor Author

Looks like the 3.2.x builds were already failing on master, so no new failures introduced here.

@JonRowe
Copy link
Member

JonRowe commented Dec 17, 2016

Yep, LGTM, thanks

@JonRowe JonRowe merged commit a099767 into rspec:master Dec 17, 2016
@maclover7 maclover7 deleted the jm-5-0-stable branch December 17, 2016 14:32
sebjacobs pushed a commit to futurelearn/rspec-rails that referenced this pull request Mar 15, 2019
* Add missing require for SourceAnnotationExtractor

* 5-0-0 --> 5-0-stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants