Fix other builds by pinning rest client #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,9 @@ group :documentation do | |||
| gem 'redcarpet', '2.3.0' | |||
| gem 'github-markup', '1.0.0' | |||
| gem 'relish' | |||
| if RUBY_VERSION '< 2.0.0' | |||
There was a problem hiding this comment.
This seems to have broken things worse. Every entry in the build matrix is failing during the bundle install phase with:
Undefined local variable or method `RUBY_VERSION' for Gemfile
JonRowe
force-pushed
the
fix_other_builds
branch
2 times, most recently
from
4809ef0 to
6d41f64
Compare
|
These changes look fine, although were you expecting them to fix 1.8.7? |
|
Yeah I did, but bundler is doing something weird. The conflict its complaining about doesn't exist :/ |
JonRowe
force-pushed
the
fix_other_builds
branch
2 times, most recently
from
7aaa7ec to
351bcd6
Compare
JonRowe
force-pushed
the
fix_other_builds
branch
from
351bcd6 to
7d427d1
Compare
|
@myronmarston this is now failing for the usual reasons on 1.8.7, and so should fix the other builds (huzzah :/) turns out theres a bundler issue with displaying dependency resolution on 1.14, 1.13 enabled me to find out what the issue was. |
|
LGTM. Do you want to merge this and then kick the builds of the other repos to see if they are indeed green? |
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
* pin rubocop for rails * limit relish to modern rubies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.