Switch template task name depending on Rails version #1796
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rake tasks `rails:update` or `rails:template` and so on were deprecated on Rails 5.0, and will be removed on Rails 5.1. So we should switch a task name. ref: * rails/rails#23439 * rails/rails@f778281
JonRowe
requested changes
Mar 23, 2017
| def template_task_name | ||
| gem 'rails' | ||
|
|
||
| if Gem.loaded_specs['rails'].version >= Gem::Version.create('5.0') |
There was a problem hiding this comment.
You should just be able to check the rails version from it's constant, we try to avoid using rubygems where possible.
There was a problem hiding this comment.
Does "check the rails version from it's constant" mean ?
require 'rails'
if Rails.version >= '5.0'
...
|
worth noting, I have patches for this in this PR also: #1790. |
|
@yui-knk if you're interested in collaborating on rails 5.1 compatibility in RSpec, I'd welcome commits on top of my WIP PR, would you be interested in helping there? |
|
Yes I'm interested in RSpec on Rails 5.1 :) I will send PR for #1790. |
|
Closing this in favour of #1790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rake tasks
rails:updateorrails:templateand so on weredeprecated on Rails 5.0, and will be removed on Rails 5.1.
So we should switch a task name.
ref: