Follow updated ruby versions in the matrix #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Nov 3, 2017
.travis.yml
Outdated
| @@ -37,7 +37,7 @@ rvm: | |||
| - 1.8.7 | |||
| - 2.4.2 | |||
| - 2.3.5 | |||
| - 2.2 | |||
| - 2.2.7 | |||
There was a problem hiding this comment.
2.2 automatically tracks the latest, but yes I forgot to update the matrix when I did everything else, can you back out the 2.2 changes and then this can be merged?
There was a problem hiding this comment.
Sure. Just reverted around 2.2 changes as c6a47a0
|
Merged despite build failure as unrelated. |
|
Thank you! |
JonRowe
pushed a commit
that referenced
this pull request
Nov 20, 2017
* Follow updated ruby versions in the matrix * Keep 2.2.n matrix as before
This was referenced Mar 20, 2018
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
* Follow updated ruby versions in the matrix * Keep 2.2.n matrix as before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have confident as these configuration, was it not tracked in the rspec-dev script? 🤔