-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Contributing updates v2 #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Contributing updates v2 #1925
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f4e41b5
Some updates for the contributing file.
142dd9c
Make some further edits to contributing.md
643fa20
Add an issue template.
8ed95b3
Make some edits to contributing and issue template.
dbceca2
Implement comments review from Ashley on #1705
benoittgt c0b215c
Remove issue template part related to Rails 5
benoittgt c275adf
Reformulate "'Has reproduction case' issues" with Yusuke proposition
benoittgt 70d5a0c
"Dev environment" is not clear enough
benoittgt 5b4ac1f
Fix typo on "reproduce"
benoittgt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
<!-- | ||
|
||
Hi there! Here's a few pointers to help us help you with your issue as quickly | ||
as possible. | ||
|
||
We prefer that the RSpec Rails issue tracker be mainly used for bug reports. | ||
Feature requests or general requests for help should go to our google group: | ||
[email protected]. We use that as our primary location for higher level | ||
RSpec discussions. | ||
|
||
If you are filing a bug report, there's a few steps it'd be super if you could | ||
follow. If you can't do all of these, don't worry, but if you can it'll help us | ||
resolve your bug faster! | ||
|
||
--> | ||
|
||
## What Ruby, Rails and RSpec versions are you using? | ||
|
||
Ruby version: | ||
Rails version: | ||
Rspec version: | ||
|
||
<!-- | ||
|
||
You can run | ||
|
||
``` | ||
bundle exec ruby --version | ||
bundle exec rails --version | ||
bundle exec rspec --version | ||
``` | ||
|
||
--> | ||
|
||
## Observed behaviour | ||
|
||
<!-- | ||
please provide a concise description of the behaviour you are observing with | ||
RSpec and Rails | ||
--> | ||
|
||
## Expected behaviour | ||
|
||
<!-- | ||
Please provide a description of what you expect to be happening, and how that | ||
differs from the current behaviour. | ||
--> | ||
|
||
## Can you provide an example app? | ||
|
||
<!-- | ||
This step is probably the most important in allowing us to quickly debug | ||
your issue, and we typically ask that you follow these steps: | ||
|
||
1. `rails new` an app at the specific version of ruby and rails that you are | ||
using | ||
2. commit that app, so that we have the rails skeleton in a separate commit | ||
3. Make all the changes necessary (adding RSpec, models, specs, controllers, | ||
etc) to reproduce the issue. There should be a failing test or tests that you | ||
expect to pass. We'll run `bundle exec rspec`, but if you can provide a | ||
readme with more detailed instructions that'd be amazing :) | ||
4. Commit | ||
5. Provide a link to a github repo, a description of the app and what you're expecting here | ||
--> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get started on
→get started
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get started on
is the correct english here, an alternative would beget started with
.