Remove the version check in have_http_status #1965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The successful?, server_error?, and not_found? methods for ActionDispatch::TestResponse have existed in Rails for a very long time. It isn't necessary to check for Rails 5.2 or greater in order to use them.
wbreeze
changed the title
|
@JonRowe So happy to be able to do this. |
|
Thanks, sorry this slipped through the cracks |
|
Thanks! |
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
The successful?, server_error?, and not_found? methods for ActionDispatch::TestResponse have existed in Rails for a very long time. It isn't necessary to check for Rails 5.2 or greater in order to use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The successful?, server_error?, and not_found? methods for ActionDispatch::TestResponse have existed in Rails for a very long time. It isn't necessary to check for Rails 5.2 or greater in order to use them.
This is an improvement on #1951 which has been merged.