Add support for asserting job is enqueued with no wait. #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
requested changes
Mar 27, 2018
| @@ -149,12 +149,17 @@ def other_attributes_match?(job) | |||
|
|
|||
| def serialized_attributes | |||
| {}.tap do |attributes| | |||
| attributes[:at] = @at.to_f if @at | |||
| attributes[:at] = serialized_at | |||
There was a problem hiding this comment.
This is not quite the same, can we do serialized_at if @at and eliminate the nil check in the method, we don't want to se this at all if it hasn't been set.
| expect { | ||
| hello_job.set(:wait_until => date).perform_later | ||
| }.to_not have_enqueued_job.at(:no_wait) | ||
| end |
There was a problem hiding this comment.
There's another scenario here, not setting at at all and there being a wait
JonRowe
approved these changes
Mar 29, 2018
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.