Test against the released version of Rails 5.2 #1986
Conversation
.travis.yml
Outdated
| @@ -141,7 +141,7 @@ matrix: | |||
| - rvm: 2.4.4 | |||
| env: RAILS_VERSION='~> 3.1.12' | |||
| - rvm: 2.4.4 | |||
| env: RAILS_VERSION=5.2.0.rc1 | |||
| env: RAILS_VERSION=5.2.0 | |||
There was a problem hiding this comment.
Ah hem, this is in the wrong place, it actually prevents 5.2.0 from running on 2.4.4, it should be include with an entry for each version it supports
There was a problem hiding this comment.
Indeed this appears to be at end of some exclusions. But, why is it here? I don’t see anything that would test against 5.2 in the first place.
Looks like I should have added entries under the include on line 60.
There was a problem hiding this comment.
Yes it's in the wrong place and no one noticed :)
|
@JonRowe I think Travis is running the expected jobs now. Please have a look. |
|
Strictly speaking I think we need to match whats been done for the 4.x series and have a tilde-whack or the stable branch added as well but I'm ok with merging this as is once green. |
|
I'm having a hard time deciphering the build failure. Does that stuff about system tests stop the spec run with a non-zero exit code? |
|
Yes it does, I'm not sure why it's being triggered, there must be some setup thats done for 5.1 that isn't working on 5.2 for some reason |
|
Any news about this PR? |
|
I'm closing this in favour of #1959. Which is green against rails 5.2. |
|
👍 thanks Sam! |
fixes #1985