Skip to content

Rails 52 improvements #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Rails 52 improvements #1990

merged 2 commits into from
Apr 24, 2018

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Apr 23, 2018

Add missing travis builds for 5.2.0 and improve an error message formatting post #1959

@JonRowe JonRowe requested a review from fables-tales April 23, 2018 09:50
@JonRowe JonRowe mentioned this pull request Apr 23, 2018
@fables-tales
Copy link
Member

@JonRowe this is likely red because it's not aligned with the patches in #1959. May want to look there.

@JonRowe
Copy link
Member Author

JonRowe commented Apr 23, 2018

@samphippen I made sure those changes where in, the red build were flakes

@JonRowe
Copy link
Member Author

JonRowe commented Apr 24, 2018

Merging as green

@JonRowe JonRowe merged commit 998d659 into master Apr 24, 2018
@JonRowe JonRowe deleted the rails_52_improvements branch April 24, 2018 10:11
@annacruz
Copy link

annacruz commented Jul 7, 2018

Hey, when we gonna have a new release with these improvements?

@JonRowe
Copy link
Member Author

JonRowe commented Jul 7, 2018

@annacruz this PR was mostly focused on improving our CI for Rails 5.2, theres a minor change to an error message and will be released in the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants