-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add gem version and semver stability badges to README #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@greysteil I'm disinclined to add the "semver stability" badge as I can't independently verify that it actually works, or is in any way meaningful in the ruby programming language. The others we will need to consider. |
👍 - I've removed that one. It works pretty well, and picks out the 3.6.1 -> 3.7.0 break, for example, but I appreciate it needs more thought than the other two. |
LGTM |
Squashed into a single commit. Pretty innocuous change now, and you can confirm it renders here. Separately, would love to talk you through the SemVer stability score if you're open to it? |
If we want to have a coverage badge we need to setup coverage, it seems I'm not a member of the organisation, who initially configured RSpec on code climate? |
Just dug into the Code Climate issue. Looks like this commit switched us to shields.io endpoint that is no longer supported, but the original URL still works. I've updated the badge accordingly: Turns out it was never meant to be coverage (my bad for switching the broken badge to that initially) - it's a "maintainability" badge. |
@greysteil Could you rebase your changes? They're neat. |
@JonRowe I'm happy to merge this on green if you are. |
I'm happy if the builds green |
Build is going to be ❌ without #2051. |
@greysteil let's rebase this now that the rubygems fix is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! 🎉
❤️ |
* Add gem version badge to README * Fix Code Climate badge
First of all, thanks for rspec-rails! I've used it on every Rails project I've ever worked on, and love it.
Would you be up for adding badges that display the current version on
rspec-rails
, and its semver stability? The former is pretty self-explanatory, the later is a new badge I've made that displays the percentage of rspec-rails users' CI runs that pass when updating rspec-rails between SemVer compatible versions. Data comes from Dependabot (disclosure: I built it).I've also fixed the Code Climate badge in this PR (the URL must have changed on shields.io).
The badges now look like this: