Use __dir__ for expand_path in rails_helper template #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.0 introduced `__dir__` pseudo variable, and we can replace it with `__FILE__` for `expand_path` method. There is a RuboCop Cop pointing this out. http://www.rubocop.org/en/latest/cops_style/#styleexpandpatharguments This change reduces one RuboCop warning after installing rspec-rails.
JonRowe
requested changes
Dec 17, 2018
There was a problem hiding this comment.
👋 Thanks for taking the time to introduce this. rspec-rails still supports Ruby 1.9.x for older versions of Rails, so for us to merge this it'll have to be gated by a check for Ruby version.
<% if RUBY_VERSION >= '2.0.0' %>
require File.expand_path('../config/environment', __dir__)
<% else %>
require File.expand_path('../../config/environment', __FILE__)
<% end %>
This will produce the right snippet into the generated file for each version.
Use `__FILE__` otherwise so that the gem can support ruby 1.9.3 and lower.
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
* Use __dir__ for expand_path in rails_helper template Ruby 2.0 introduced `__dir__` pseudo variable, and we can replace it with `__FILE__` for `expand_path` method. There is a RuboCop Cop pointing this out. http://www.rubocop.org/en/latest/cops_style/#styleexpandpatharguments This change reduces one RuboCop warning after installing rspec-rails. * Use `__dir__` only when RUBY_VERSION >= 2.0 Use `__FILE__` otherwise so that the gem can support ruby 1.9.3 and lower.
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.0 introduced
__dir__pseudo variable, and we can replace it with__FILE__forexpand_pathmethod.There is a RuboCop Cop pointing this out.
http://www.rubocop.org/en/latest/cops_style/#styleexpandpatharguments
This change reduces one RuboCop warning after installing rspec-rails.