Skip to content

System Spec feature: include System Tests text #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

olleolleolle
Copy link
Contributor

This PR introduces a few sentences from the Rails documentation on System Testing.

Goals:

  1. keep more of the story in the same document - easier to navigate
  2. tell the story in an rspec-rails frame - talk about how to get things done in this spec

When we close in on those goals, perhaps the link to the System Tests documentation can be de-emphasised.

Questions for reviewer

  • What is the smallest iterative step we can take towards those goals?
  • Should this PR include more Scenarios?

@fables-tales
Copy link
Member

@olleolleolle I think it might be good to document that this runs your tests in a transaction, and so unlike feature specs with javascript, you don't need database cleaner.

@fables-tales
Copy link
Member

I'm happy to merge this as is. I'm the wrong person to write the documentation here though, as I have a very detailed understanding of how this works, and thererfore don't know what isn't obvious. @olleolleolle do you think anything else is missing from our docs?

@olleolleolle
Copy link
Contributor Author

@samphippen I'll just fix a typo, and add a note that Capybara's auto-required for a system spec.

@olleolleolle
Copy link
Contributor Author

@samphippen There.

Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement overall, a few notes.

@olleolleolle
Copy link
Contributor Author

I changed wordings.

Thanks for caring and giving such actionable feedback on this PR.

This is good progress for a short sitting, I'm pleased.

@olleolleolle olleolleolle force-pushed the add-docs-about-system-testing branch from c1dc56c to 315406c Compare December 19, 2018 22:36
@olleolleolle olleolleolle force-pushed the add-docs-about-system-testing branch from 315406c to be80338 Compare December 20, 2018 10:02
@fables-tales fables-tales merged commit b1dff4b into rspec:master Dec 20, 2018
@olleolleolle olleolleolle deleted the add-docs-about-system-testing branch December 20, 2018 12:49
benoittgt pushed a commit to benoittgt/rspec-rails that referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants