-
-
Notifications
You must be signed in to change notification settings - Fork 1k
added generator spec generator and spec tests #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5b3597b
added generator generator and spec tests
ConSou 46daaa3
revisions to remove unnessary checking of rails v and generator templ…
ConSou 5cd64d6
fixes indention issue
ConSou ef67f64
changed directory name
ConSou dcffc60
renamed directories
ConSou 5c7d74f
fixed issues causing failing tests
ConSou e8401c6
fixed indentation, changed default to false and made adjustmetns to spec
ConSou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
require 'generators/rspec' | ||
|
||
module Rspec | ||
module Generators | ||
# @private | ||
class GeneratorsGenerator < Base | ||
class_option :generator_specs, :type => :boolean, :default => false, :desc => "Generate generator specs" | ||
|
||
def generate_generator_spec | ||
return unless options[:generator_specs] | ||
|
||
template template_name, File.join('spec/generator', class_path, filename) | ||
end | ||
|
||
def template_name | ||
'generator_spec.rb' | ||
end | ||
|
||
def filename | ||
"#{table_name}_generator_spec.rb" | ||
end | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
require 'rails_helper' | ||
|
||
RSpec.describe "<%= class_name.pluralize %>", <%= type_metatag(:generator) %> do | ||
|
||
pending "add some scenarios (or delete) #{__FILE__}" | ||
end |
35 changes: 35 additions & 0 deletions
35
spec/generators/rspec/generators/generator_generator_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
require 'generators/rspec/generators/generator_generator' | ||
require 'support/generators' | ||
|
||
RSpec.describe Rspec::Generators::GeneratorsGenerator, :type => :generator do | ||
setup_default_destination | ||
|
||
describe "generator specs" do | ||
subject(:generator_spec) { file("spec/generator/posts_generator_spec.rb") } | ||
describe "are generated independently/can be generated" do | ||
before do | ||
run_generator %w(posts --generator-specs) | ||
end | ||
it "creates the spec file" do | ||
expect(generator_spec).to exist | ||
end | ||
it "contains 'rails_helper in the spec file'" do | ||
expect(generator_spec).to contain(/require 'rails_helper'/) | ||
end | ||
it "includes the generator type in the metadata" do | ||
expect(generator_spec).to contain(/^RSpec.describe \"Posts\", #{type_metatag(:generator)}/) | ||
end | ||
end | ||
|
||
describe "are not generated/are skipped by default" do | ||
before do | ||
run_generator %w(posts) | ||
end | ||
describe "the spec" do | ||
it "does not exist" do | ||
expect(generator_spec).to_not exist | ||
end | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.