[ruby-head] Turn value into a String before regex match #2106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
changed the title
olleolleolle
force-pushed
the
try-avoiding-a-ruby-head-thing
branch
from
3136fd3 to
d77f8a7
Compare
|
There's also the possibility of defaulting to |
|
I'm happy with this as it is now it passes, thanks :) |
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
JonRowe
pushed a commit
that referenced
this pull request
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is tries to avoid a warning output in 2.7.0 (
ruby-head), which causes a test failure inrspec-core:Error in rspec-core Travis build
This PR turns the value (
version) being matched with=~into a String, first.The change to ruby was introduced in https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?revision=65989&view=revision