Rename two Rubocop cops in config that break the build #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it) The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it)
JonRowe
pushed a commit
that referenced
this pull request
Oct 3, 2019
Fix: Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it) The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
Error: The
Layout/FirstParameterIndentationcop has been renamed toLayout/IndentFirstArgument.(obsolete configuration found in .rubocop_rspec_base.yml, please update it)
The
Layout/IndentArraycop has been renamed toLayout/IndentFirstArrayElement.(obsolete configuration found in .rubocop_rspec_base.yml, please update it)
I push this fix to 4-0-dev already #2071 (comment)