address rubocop offenses: #2126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix warnings for wrong namespaces - fix safe navigation offense - turn off frozen string literal cop
JonRowe
reviewed
May 13, 2019
| @@ -22,7 +22,7 @@ module MailerExampleGroup | |||
| included do | |||
| include ::Rails.application.routes.url_helpers | |||
| options = ::Rails.configuration.action_mailer.default_url_options | |||
| options.each { |key, value| default_url_options[key] = value } if options | |||
| options&.each { |key, value| default_url_options[key] = value } | |||
There was a problem hiding this comment.
What versions of Ruby does that operator support?
There was a problem hiding this comment.
>= 2.3.. v4 will drop support for ruby below 2.3, so using lonely operator should be safe..
benoittgt
approved these changes
May 13, 2019
|
Thanks :) |
|
Yeha! Thanks Jon and Ignatius |
benoittgt
pushed a commit
that referenced
this pull request
Aug 21, 2019
- fix warnings for wrong namespaces - fix safe navigation offense - turn off frozen string literal cop
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
Aug 24, 2019
- fix warnings for wrong namespaces - fix safe navigation offense - turn off frozen string literal cop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubocop released new version, which break our CI..
PS: let me know if I should open this against master instead..