Skip to content

Pin minitest on older Rubies #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 23, 2019
Merged

Pin minitest on older Rubies #2174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aa4f0cb
Move issue template
Aug 16, 2019
3a893a8
Add feature request template
Aug 16, 2019
f5f27cd
Link to issue templates in CONTRIBUTING.md
Aug 16, 2019
7d42e08
Provide instructions in issue templates
Aug 26, 2019
7f5dd6d
Pin minitest on older Rubies
JonRowe Sep 23, 2019
9b56320
Downgrade bundler on any old rails version
JonRowe Sep 23, 2019
92f5ef5
Merge branch '4-0-dev' into fix-build-4-0-dev
JonRowe Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions ISSUE_TEMPLATE.md → .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
<!--
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

Hi there! Here's a few pointers to help us help you with your issue as quickly
as possible.
---

We prefer that the RSpec Rails issue tracker be mainly used for bug reports.
Feature requests or general requests for help should go to our google group:
[email protected]. We use that as our primary location for higher level
RSpec discussions.
<!--

If you are filing a bug report, there's a few steps it'd be super if you could
follow. If you can't do all of these, don't worry, but if you can it'll help us
Below are a few steps it'd be super if you could follow.
If you can't do all of these, don't worry, but if you can it'll help us
resolve your bug faster!

-->
Expand Down
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

---

<!--

Feature requests or general requests for help should first go to our google group:
[email protected]. We use that as our primary location for higher level
RSpec discussions.

-->

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ We welcome contributions from *everyone*. While contributing, please follow the
If you'd like to help make RSpec better, here are some ways you can contribute:

- by running RSpec HEAD to help us catch bugs before new releases
- by [reporting bugs you encounter](https://github.com/rspec/rspec-rails/issues/new)
- by [suggesting new features](https://github.com/rspec/rspec-rails/issues/new)
- by [reporting bugs you encounter](https://github.com/rspec/rspec-rails/issues/new?template=bug_report.md)
- by [suggesting new features](https://github.com/rspec/rspec-rails/issues/new?template=feature_request.md)
- by improving RSpec's [Relish](https://relishapp.com/rspec) or [API](http://rspec.info/documentation/) documentation
- by improving [RSpec's website](http://rspec.info/) ([source](https://github.com/rspec/rspec.github.io))
- by taking part in [feature and issue discussions](https://github.com/rspec/rspec-rails/issues)
Expand Down
5 changes: 5 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ gem 'rake', '~> 12'

gem 'mime-types', "~> 3"

# Version 5.12 of minitest requires Ruby 2.4
if RUBY_VERSION < '2.4.0'
gem 'minitest', '< 5.12.0'
end

gem 'capybara', '~> 2.13', :require => false

if MAJOR == 6
Expand Down