Switch all links to HTTPS #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aried3r
commented
Oct 9, 2019
BUILD_DETAIL.md
Outdated
Comment on lines
71
to
73
| RSpec uses [YARD](https://yardoc.org/) for API documentation on the [rspec.info | ||
| site](https://rspec.info/). | ||
| Our commitment to [SemVer](https://semver.org) requires that we explicitly |
There was a problem hiding this comment.
Reformatted so it's 80 char width like the rest of the document.
features/README.md
Outdated
Comment on lines
44
to
48
| Cucumber features over time, and clarifying existing ones. If you have specific | ||
| features you'd like to see added, find the existing documentation incomplete or | ||
| confusing, or, better yet, wish to write a missing Cucumber feature yourself, | ||
| please [submit an issue](https://github.com/rspec/rspec-rails/issues) or a [pull | ||
| request](https://github.com/rspec/rspec-rails). |
There was a problem hiding this comment.
Reformatted to 80-char width
There was a problem hiding this comment.
Can you undo this, its formatted for relish.
| @@ -6,7 +6,7 @@ source $SCRIPT_DIR/travis_functions.sh | |||
| source $SCRIPT_DIR/predicate_functions.sh | |||
|
|
|||
| # If JRUBY_OPTS isn't set, use these. | |||
| # see http://docs.travis-ci.com/user/ci-environment/ | |||
| # see https://docs.travis-ci.com/user/reference/overview/ | |||
There was a problem hiding this comment.
This is where the old link redirects right now. It doesn't mention JRUBY_OPTS or env variables at all, so I'm wondering if that's the correct link?
Closed
|
I have addressed the issues you mentioned. :) |
JonRowe
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.