Fix Rails version env var format in Travis config #2227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
downgrade_bundler_on_old_rails has a check for Rails < 5, and it false triggered for builds where RAILS_VERSION had two digits.
|
👍 Whilst this does have different semantics, I'm ok with putting this back to a full version. |
|
Yep, I though that this will miss 6.0 when 6.1 is out, but pretty sure we'll ajdust the config by that time. |
|
We'd have to add 6.0 anyway, so its no harm |
JonRowe
pushed a commit
that referenced
this pull request
Jan 12, 2020
downgrade_bundler_on_old_rails has a check for Rails < 5, and it false triggered for builds where RAILS_VERSION had two digits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downgrade_bundler_on_old_railshas a check for Rails < 5, and it false triggered for builds where RAILS_VERSION had two digits.Example builds: before, after.