Add documentation and feature test on headers setup in controller spec #2229

benoittgt · 2019-12-12T08:27:35Z

Hello

This is the answer to #1655 (comment)
Feel free to comment on any wording issue. I will be happy to do correction.

I will be very happy to close this old issue.

Close: #1655

pirj

Thanks!

features/controller_specs/README.md

JonRowe

Looking good I mostly have grammatical tweaks here, might have to preview it on relish to check it renders ok

features/controller_specs/headers.feature

features/controller_specs/README.md

benoittgt · 2019-12-14T14:40:33Z

might have to preview it on relish to check it renders ok

@JonRowe I don't have any Relish credentials for the staging env. I tried:

$ relish push rspec-staging/rspec-rails

JonRowe · 2019-12-14T17:22:53Z

Aha turns out neither do ! @myronmarston / @penelopezone ?

myronmarston · 2019-12-15T06:11:43Z

Aha turns out neither do ! @myronmarston / @penelopezone ?

I don't have access to rspec-staging/rspec-rails, either:

I went ahead and granted @JonRowe access to the other rspec-staging projects, though.

@benoittgt I tried granting you access but relish tells me there's no user with the email address I have for you. I trust @JonRowe can grant you access to the various projects when you work out what email address you use for your relish user.

BTW, bear in mind that there's nothing special about rspec-staging: y'all could create staging-rspec or some other project for this purpose if you can't get access to rspec-staging.

Anyhow, un-subbing from this thread. Hard for me to find time to work on things like this these days.

example_app_generator/generate_app.rb

JonRowe · 2019-12-17T09:37:40Z

Thanks Myron (not @'d so he's not pinged but if he reads this, thank you!)

@benoittgt it seems there is no staging project for rspec-rails, @mattwynne are you able to help here? I know new projects are turned off which might be why I can't create a staging project for rspec-rails?

mattwynne · 2019-12-17T17:14:58Z

If new projects are turned off I'd forgotten about that. I thought we'd just disabled sign-ups.

If that's really the case I can probably do something for you via the rails console. What exactly do you need done?

JonRowe · 2019-12-17T19:25:24Z

@mattwynne well I can't run relish projects:add rspec-staging/rspec-rails I sort of assumed that was related to the sunset, my apologies if not as the project seems not to exist

mattwynne · 2019-12-24T16:08:18Z

@mattwynne well I can't run relish projects:add rspec-staging/rspec-rails I sort of assumed that was related to the sunset, my apologies if not as the project seems not to exist.

@JonRowe that's odd, it works for me (with a different org / project). Do you see an error?

JonRowe · 2019-12-24T16:15:42Z

@JonRowe that's odd, it works for me (with a different org / project). Do you see an error?

It tells me that I'm not a collaborator on the organisation, which I am? and there appears to be no project there, I guess its possible theres an empty one someone created?

pirj · 2020-01-08T20:45:16Z

@mattwynne Did you have a chance to look at this?

mattwynne · 2020-01-09T15:03:07Z

Thanks for the nudge @pirj.

@JonRowe I checked in the console. I think the problem was that you weren't, in fact, a member of the rspec-staging org, just the projects beneath it. So only Myron (who created the org) had permission to create new projects.

I've added you as a member of the org now @JonRowe so can you try again?

JonRowe · 2020-01-09T16:29:24Z

Yep that works, thanks @mattwynne! @benoittgt what is your relish username or email?

benoittgt · 2020-01-09T20:34:11Z

Oups sorry.

I don't have any, and registrations are close. If I can have an account with *** it will be perfect.

benoittgt · 2020-01-09T21:23:29Z

Thanks @mattwynne for the invit. Sadly when I click on the link I get redirected to this page http://relishapp.com/users/sign_up (I have extra param with invite_code)

mattwynne · 2020-01-09T21:29:22Z

Gah.

I created you an account with a random password @benoittgt. Can you try using the password reset password form now?

benoittgt · 2020-01-09T21:40:20Z

Thanks @mattwynne. I just did it. @JonRowe you should be able to find me. Username "benoit", email "benoit @t hopsandfork dot com"

mattwynne · 2020-01-09T21:47:55Z

Great stuff, and props to you and the team for maintaining this exemplary suite of living docs for so many years!

JonRowe · 2020-01-09T23:01:26Z

Done @benoittgt, you should have access to them all

benoittgt · 2020-01-09T23:20:32Z

Not super happy with how sentences are splited. See:

But otherwise I think it could be merged.

pirj · 2020-01-09T23:34:16Z

Looks like a bug - a newline is turned into a <br/>, I'll open a ticket for yard.

JonRowe · 2020-01-10T09:42:40Z

@benoittgt @pirj thats normal, its just how relish renders, the lines in features need to be longer to allow them to wrap on relish IIRC

pirj · 2020-01-10T10:52:12Z

Awesome, let's merge then and address wrapped lines later.

JonRowe · 2020-01-10T13:03:29Z

@pirj might as well fix it here as this PR is a documentation PR...

benoittgt · 2020-01-10T19:59:22Z

Here we go:

pirj

Looks good! Thanks.

pirj · 2020-01-10T20:06:59Z

features/controller_specs/headers.feature

+  We recommend you to switch to request specs instead of controller specs if you want to set
+  headers in your call.
+  If you still want to set headers in controller specs, you can use `request.headers` as
+  mentioned bellow.


Maybe also keep it as once sentence per line?

I thought about it but the lines were pretty long in code. I push to staging then cut the line in the core where Relish was wrapping lines. :)

pirj · 2020-01-10T20:48:22Z

I'm taking care of CI failures - rack 2.1.0 has been released with a deprecation message, and rails is not patched yet to use the new API.

JonRowe

Looking good, some grammatical tweaks having seen it on the HTML page.

features/controller_specs/headers.feature

features/controller_specs/README.md

benoittgt · 2020-01-10T23:03:26Z

I just pushed on staging. Looks better with your review @JonRowe

features/controller_specs/setting_request_headers.feature

pirj approved these changes Dec 12, 2019

View reviewed changes

features/controller_specs/README.md Outdated Show resolved Hide resolved

JonRowe requested changes Dec 14, 2019

View reviewed changes

JonRowe approved these changes Dec 14, 2019

View reviewed changes

benoittgt mentioned this pull request Dec 15, 2019

Last update of Thor break "rails generate controller" on 4.2 rails/rails#37978

Closed

benoittgt force-pushed the request-header-doc branch from d355486 to 15a5e78 Compare December 15, 2019 18:44

JonRowe reviewed Dec 16, 2019

View reviewed changes

example_app_generator/generate_app.rb Outdated Show resolved Hide resolved

benoittgt force-pushed the request-header-doc branch from 15a5e78 to 5234861 Compare December 16, 2019 09:32

benoittgt force-pushed the request-header-doc branch 2 times, most recently from be4e2c1 to fdd97dd Compare December 20, 2019 13:09

benoittgt closed this Jan 9, 2020

benoittgt reopened this Jan 9, 2020

pirj approved these changes Jan 10, 2020

View reviewed changes

pirj reviewed Jan 10, 2020

View reviewed changes

JonRowe reviewed Jan 10, 2020

View reviewed changes

benoittgt added 5 commits January 11, 2020 13:37

Add feature test for headers setup in controller specs

5dc8ff3

Add documentation about http headers into controller spec

0d3930b

Grammatical tweaks

b16e5df

Avoid line split in relish doc

cfe0d70

Rename header feature spec, line break change, avoid short sentences

fd14c8a

pirj force-pushed the request-header-doc branch from af44f0a to fd14c8a Compare January 11, 2020 10:37

pirj reviewed Jan 11, 2020

View reviewed changes

features/controller_specs/setting_request_headers.feature Show resolved Hide resolved

Fix typo in "type: :controller"

4a42588

benoittgt merged commit 0362190 into master Jan 11, 2020

benoittgt deleted the request-header-doc branch January 11, 2020 13:27

Uh oh!

Add documentation and feature test on headers setup in controller spec #2229

Add documentation and feature test on headers setup in controller spec #2229

Uh oh!

Conversation

benoittgt commented Dec 12, 2019

Uh oh!

pirj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JonRowe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benoittgt commented Dec 14, 2019

Uh oh!

JonRowe commented Dec 14, 2019

Uh oh!

myronmarston commented Dec 15, 2019

Uh oh!

Uh oh!

JonRowe commented Dec 17, 2019

Uh oh!

mattwynne commented Dec 17, 2019

Uh oh!

JonRowe commented Dec 17, 2019

Uh oh!

mattwynne commented Dec 24, 2019

Uh oh!

JonRowe commented Dec 24, 2019

Uh oh!

pirj commented Jan 8, 2020

Uh oh!

mattwynne commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonRowe commented Jan 9, 2020

Uh oh!

benoittgt commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benoittgt commented Jan 9, 2020

Uh oh!

mattwynne commented Jan 9, 2020

Uh oh!

benoittgt commented Jan 9, 2020

Uh oh!

mattwynne commented Jan 9, 2020

Uh oh!

JonRowe commented Jan 9, 2020

Uh oh!

benoittgt commented Jan 9, 2020

Uh oh!

pirj commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonRowe commented Jan 10, 2020

Uh oh!

pirj commented Jan 10, 2020

Uh oh!

JonRowe commented Jan 10, 2020

Uh oh!

benoittgt commented Jan 10, 2020

Uh oh!

pirj left a comment

Choose a reason for hiding this comment

Uh oh!

pirj Jan 10, 2020

Choose a reason for hiding this comment

Uh oh!

benoittgt Jan 10, 2020

Choose a reason for hiding this comment

Uh oh!

pirj commented Jan 10, 2020

mattwynne commented Jan 9, 2020 •

edited

Loading

benoittgt commented Jan 9, 2020 •

edited

Loading

pirj commented Jan 9, 2020 •

edited

Loading