Fix RUBYOPT usages #2233
Fix RUBYOPT usages #2233
Conversation
pirj
force-pushed
the
fix-rubyopt-usage
branch
from
8b52295 to
f285e69
Compare
|
Don't you think all of those changes should be done on rspec-dev? |
|
No I don't think these are necessary, unsetting rubyopts would have no affect if we were wrong about the rubyopts option we used. So this might be updated on later rubies but must be still valid... |
|
It seems that Ruby is tolerable, and both |
|
The |
|
It worked differently for some reason: $ A='1'
$ B=$A:' 2'
$ echo $B
1: 2 |
|
My bad, I think it's actually just a $PATH thing |
|
@pirj do you think you could rebase from master? |
pirj
force-pushed
the
fix-rubyopt-usage
branch
from
f285e69 to
2ab6b04
Compare
|
Done, rebased. |
|
Thanks. This should normally help us for the next step rubygems/bundler#7505 I am happy to merge this to rspec-dev (#2239) |
|
If we don't think this will change anything on the build, (I don't, but I'm willing to be convinced) I'd like to hold off making any changes with this until we have a green build. |
There's a warning regarding an unknown argument to `--disable`, and it seems that `--disable=gem` is not entirely correct, should be `--disable=gems` [Documentation](https://docs.ruby-lang.org/ja/latest/doc/spec=2frubycmd.html) (in Japanese). Example output: ruby: warning: unknown argument for --disable: `gem:' ruby: warning: features are [gems, did_you_mean, rubyopt, frozen_string_literal]. ruby: warning: unknown argument for --enable: `rubygems' ruby: warning: features are [gems, did_you_mean, rubyopt, frozen_string_literal].
pirj
force-pushed
the
fix-rubyopt-usage
branch
from
2ab6b04 to
ebc5ff3
Compare
|
Also green. |
|
Does this make a difference? I'm inclined to leave it be otherwise? |
|
Not a big deal, just two warnings less in the build. Can be addressed later. |
There's a warning regarding an unknown argument to
--disable, and it seems that--disable=gemis not entirely correct, should be--disable=gems.Documentation (in Japanese).
Example output: