Small doc improvement #2250
Small doc improvement #2250
Conversation
|
|
Bundler again. (ಠ_ಠ) rubygems install bundler 2.1.2, then we install bundler 2.1.3 but we choose the wrong version when executing I was working on a small reproduction script to try to answer to rubygems/bundler#7487 (comment) At the moment I do $ rvm use 2.7 && rm -f Gemfile.lock && export RAILS_VERSION='~>6.0' && bundle --binstubs && bundle exec rake smoke:app
# no problem
$ bundle exec rake cucumber
# 💥And it breaks. I will try to narrow it tomorrow. 💤 |
|
😢 |
|
Technically, I think its the generated sub apps that are the issue. |
|
Ok I look a little bit and it seems there is something with I look a little bit how aruba works but I am not sure I understand how
If I use the Maybe @mvz you have an idea? EDIT1: CI is green |
With new bundler update like 2.1.2 and 2.1.3 we saw issues on the CI after running `bundle exec cucumber`: ``` +/home/travis/.rvm/gems/ruby-2.6.3/gems/bundler-2.1.3/lib/bundler/runtime.rb:312:in `check_for_activated_spec!': You have already activated bundler 2.1.2, but your Gemfile requires bundler 2.1.3. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError) ``` Using the patch from mvz #2241 reduce the amount of error
|
I push this commit for CI testing purpose. |
|
Ok it is working... For f1b5011 I simply copy past it. I am not confident to merge without a re-review. |
benoittgt
dismissed stale reviews from JonRowe and pirj
Some code added that need re-review
|
@mvz do you mind to approve/criticise this approach? |
| in_current_directory do | ||
| super(exec_cmd, timeout) | ||
| with_unbundled_env do |
There was a problem hiding this comment.
This call to with_unbundled_env is probably not needed.
There was a problem hiding this comment.
So I tried without
And it breaked the build. So I rollback.
There was a problem hiding this comment.
That's surprising and I'm a little concerned that I don't know what is going on in my own fix, but if it works for now, I guess it's ok. Thanks for checking this, anyway.
|
Thanks for the review you all. I will be happy if the CI break a little bit less. 😄 Happy new year. |
|
I just reran the CI on master to try the last Bundler release 2.1.4. And no issues. |
I saw missing links or invalid private class information while looking at rspec-rails documentation.