Skip to content

fix docs matcher links #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

fix docs matcher links #2259

merged 1 commit into from
Jan 10, 2020

Conversation

mkamensky
Copy link
Contributor

Fix links to matchers in the job specs description

@benoittgt
Copy link
Member

Tested and it's good to me:
Capture d’écran 2020-01-10 à 21 01 24

Maybe we could switch to a list with - to make it more readable but that's not a blocker

benoittgt
benoittgt approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

pirj
pirj approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JonRowe JonRowe merged commit c632de3 into rspec:master Jan 10, 2020
JonRowe added a commit that referenced this pull request Jan 12, 2020
@JonRowe
Merge pull request #2259 from mkamensky/doc-links
6a700c7 
fix docs matcher links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

@benoittgt benoittgt benoittgt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkamensky @benoittgt @pirj @JonRowe