Get rid of rack warning #2260
Merged
Get rid of rack warning #2260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rack 2.1.0 introduces a deprecation warning rack/rack@626272b#diff-894804c816a11584eb28499cb8bbe396R6 that rails is triggering, https://github.com/rails/rails/blob/1e14a2405b5e19b6758842dbd6d377c68d7f57ae/actionpack/lib/action_dispatch/middleware/static.rb#L20 but in later versions this warning will be removed rack/rack@f80e65d#diff-894804c816a11584eb28499cb8bbe396L6 This warning was causing CI failures on rack 2.1.0: rack 2.0.8: https://travis-ci.org/rspec/rspec-rails/jobs/635322909 rack 2.1.0: https://travis-ci.org/rspec/rspec-rails/jobs/635434487
pirj
force-pushed
the
fix-rack-warning
branch
from
c3436c1 to
9a03b2c
Compare
|
Looks green. Please approve/merge at will to give way to other pull requests. @JonRowe @benoittgt |
|
I'll go ahead and merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rack 2.1.0 introduces a deprecation warning
rack/rack@626272b#diff-894804c816a11584eb28499cb8bbe396R6
that rails is triggering,
https://github.com/rails/rails/blob/1e14a2405b5e19b6758842dbd6d377c68d7f57ae/actionpack/lib/action_dispatch/middleware/static.rb#L20
but in later versions this warning will be removed
rack/rack@f80e65d#diff-894804c816a11584eb28499cb8bbe396L6
This warning was causing CI failures on rack 2.1.0:
rack 2.0.8: https://travis-ci.org/rspec/rspec-rails/jobs/635322909
rack 2.1.0: https://travis-ci.org/rspec/rspec-rails/jobs/635434487