Improve ASCII tree representation in docs #2294

pirj · 2020-03-21T00:44:47Z

No description provided.

pirj · 2020-03-21T00:45:36Z

features/directory_structure.feature

@@ -36,10 +36,10 @@ Feature: Directory Structure
  `RSpec.describe` block with the `type: :controller` metadata:

  ```ruby
-  # spec/legacy/things_controller_spec.rb
+  # spec/legacy/things_controller_spec.rb


It seems that the "weird character" is there for a reason, it tricks gherkin parser to ignore the comment because otherwise, the parser expects the free-form description to end after the comment. The original pull request doesn't explain nor highlight that it was done. I'll revert this change.
Tried newer cucumber/gherkin just to make sure it's not a bug in earlier versions.

pirj · 2020-03-21T00:46:06Z

features/directory_structure.feature

      └── views
-          ├── books
+          └── books


Sincerely yours, ASCII artist.

JonRowe · 2020-03-21T10:04:58Z

Merge when green.

benoittgt · 2020-03-22T13:34:39Z

Again error on jruby but it seems different this time... But maybe link to jruby/jruby#6125

An error occurred while loading spec_helper. - Did you mean?

                    rspec ./spec/spec_helper.rb

Failure/Error:

  ControllerAssertionDelegator = RSpec::Rails::AssertionDelegator.new(

    ActionDispatch::Assertions::RoutingAssertions

  )

LoadError:

  no such file to load -- racc/info

# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:291:in `block in require'

# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:257:in `load_dependency'

# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:291:in `require'

# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:291:in `block in require'

# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:257:in `load_dependency'

# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/activesupport-5.2.4.2/lib/active_support/dependencies.rb:291:in `require'

# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/nokogiri-1.9.1-java/lib/nokogiri/css/parser.rb:7:in `<main>'

pirj · 2020-03-22T14:04:39Z

Yep. And in another case (Rails 6.0) the error is different:

An error occurred while loading spec_helper.
Failure/Error: require 'rails/all'

NameError:
  uninitialized constant ActionDispatch::Routing::RouteSet
# /home/travis/build/rspec/bundle/jruby/2.5.0/gems/railties-6.0.2.2/lib/rails/engine.rb:537:in `routes'

pirj · 2020-03-22T14:05:41Z

Rails 6.0.2.2 is out

pirj · 2020-03-22T14:26:13Z

Filed jruby/jruby#6131

benoittgt · 2020-03-22T14:31:29Z

To be honest, I am surprised that CI errors from other dependencies are so often catch by our CI.

I don't think we are living that much on the edge with unstable release.

JonRowe · 2020-03-23T08:32:21Z

Can we change to a more stable version of JRuby?

JonRowe · 2020-03-23T08:36:31Z

Lets see what happens to #2296 (edit, no effect)

benoittgt · 2020-03-24T14:28:07Z

One answer ruby/racc#132 (comment)

~~Different error now.~~ No jruby/jruby#6131

pirj · 2020-03-24T14:41:56Z

I'm waiting for Travis to update their RVM cache http://rubies.travis-ci.org/ubuntu/14.04/x86_64/jruby-head to the release that would include the fix to racc.
Strongly doubt that it will fix the second issue with uninitialized constant ActionDispatch::Routing::RouteSet though.

JonRowe · 2020-03-24T14:49:55Z

I think we can just set allow failures for now...

pirj · 2020-03-24T17:19:52Z

Chances are it'll never recover, and the number of those job issues will grow. E.g. I expect to see a Rails-related failure next when racc/info is fixed.

We're in a tricky situation here. Rails doesn't ensure compatibility with JRuby, not to say the bleeding edge of it, JRuby doesn't ensure compatibility with RSpec nor RuboCop that we use as part of our build.

What we can do:

extract RuboCop part from the main build, and only run it for 2.3, 2.4, 2.5, 2.6 and 2.7, skip it for JRuby, as the syntax is basically the same (as 2.5) - less possibilities to fail, more coverage, more total builds, total run time probably on par
propose JRuby to take care of adding builds for Rails, 5.2, and 6-stable so that in case they make some breaking changes, they don't get merged (and if Rails patch version breaks JRuby, they know of it, not us reporting it) - our jruby-head builds don't suffer

WDYT?

JonRowe · 2020-03-24T20:51:34Z

I'm fine with reducing our jruby build to not run rubocop

pirj · 2020-03-25T14:28:48Z

Surprisingly enough, the build is green.

JonRowe · 2020-03-25T14:40:06Z

Surprisingly enough, the build is green.

Yes because I allowed failures from jruby

pirj · 2020-03-25T14:51:21Z

I mean both JRuby jobs were green https://travis-ci.org/github/rspec/rspec-rails/jobs/665433957 https://travis-ci.org/github/rspec/rspec-rails/jobs/665433954

JonRowe · 2020-03-25T15:06:37Z

😂 Maybe we can already undo my changes then

benoittgt · 2020-03-25T18:22:34Z

Maybe because of ruby/racc#132 (comment) ?

pirj · 2020-03-25T18:58:39Z

IDK, I expected

NameError:
  uninitialized constant ActionDispatch::Routing::RouteSet

to remain, but it fixed itself :D

This reverts commit 3e36b8f. Related: - #2294 (comment)

pirj self-assigned this Mar 21, 2020

pirj commented Mar 21, 2020

View reviewed changes

benoittgt approved these changes Mar 21, 2020

View reviewed changes

JonRowe approved these changes Mar 21, 2020

View reviewed changes

Improve ASCII tree

59d1e55

pirj force-pushed the fix-doc-layout branch from 42166b7 to 59d1e55 Compare March 22, 2020 10:11

pirj changed the title ~~Remove weird symbols~~ Improve ASCII tree representation in docs Mar 23, 2020

benoittgt approved these changes Mar 24, 2020

View reviewed changes

pirj merged commit eb3377b into master Mar 25, 2020

pirj deleted the fix-doc-layout branch March 25, 2020 14:28

benoittgt added a commit that referenced this pull request Mar 25, 2020

Revert "Suspend jruby temporarily" because it is working now

dc019d7

This reverts commit 3e36b8f. Related: - #2294 (comment)

benoittgt mentioned this pull request Mar 25, 2020

Revert "Suspend jruby temporarily" because it is working now #2300

Merged

benoittgt added a commit that referenced this pull request Mar 25, 2020

Revert "Suspend jruby temporarily" because it is working now

0cafe7f

This reverts commit 3e36b8f. Related: - #2294 (comment)

Uh oh!

Improve ASCII tree representation in docs #2294

Improve ASCII tree representation in docs #2294

Uh oh!

Conversation

pirj commented Mar 21, 2020

Uh oh!

pirj Mar 21, 2020

Choose a reason for hiding this comment

Uh oh!

pirj Mar 22, 2020

Choose a reason for hiding this comment

Uh oh!

pirj Mar 21, 2020

Choose a reason for hiding this comment

Uh oh!

JonRowe commented Mar 21, 2020

Uh oh!

benoittgt commented Mar 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pirj commented Mar 22, 2020

Uh oh!

pirj commented Mar 22, 2020

Uh oh!

pirj commented Mar 22, 2020

Uh oh!

benoittgt commented Mar 22, 2020

Uh oh!

JonRowe commented Mar 23, 2020

Uh oh!

JonRowe commented Mar 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benoittgt commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pirj commented Mar 24, 2020

Uh oh!

JonRowe commented Mar 24, 2020

Uh oh!

pirj commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonRowe commented Mar 24, 2020

Uh oh!

pirj commented Mar 25, 2020

Uh oh!

JonRowe commented Mar 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pirj commented Mar 25, 2020

Uh oh!

JonRowe commented Mar 25, 2020

Uh oh!

benoittgt commented Mar 25, 2020

Uh oh!

pirj commented Mar 25, 2020

Uh oh!

Uh oh!

benoittgt commented Mar 22, 2020 •

edited

Loading

JonRowe commented Mar 23, 2020 •

edited

Loading

benoittgt commented Mar 24, 2020 •

edited

Loading

pirj commented Mar 24, 2020 •

edited

Loading

JonRowe commented Mar 25, 2020 •

edited

Loading