Skip to content

Temporarily allow jruby-head failures on CI #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

pirj
Copy link
Member

@pirj pirj commented Apr 3, 2020

There's a pull request pending to fix JRuby's deprecation messages, however some specs there fail, and there's no certainty when it will be merged.
jruby/jruby#6166

@pirj pirj self-assigned this Apr 3, 2020
There's a pull request pending to fix JRuby's deprecation messages,
however some specs there fail, and there's no certainty when it will be
merged.
jruby/jruby#6166
@pirj pirj force-pushed the allow-jruby-head-failures branch from 0dc2aed to 6034c0f Compare April 3, 2020 20:40
@pirj
Copy link
Member Author

pirj commented Apr 3, 2020

No idea why Travis ignores this commit which is identical to 3e36b8f8

@pirj
Copy link
Member Author

pirj commented Apr 3, 2020

There's actually this build in progress https://travis-ci.org/github/rspec/rspec-rails/builds/670747088
And two passed ones https://travis-ci.org/github/rspec/rspec-rails/builds/670745650 https://travis-ci.org/github/rspec/rspec-rails/builds/670747062
Might be some hooks failed to properly display checks.

@JonRowe @benoittgt Good to merge?

Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Thanks @pirj

@JonRowe
Copy link
Member

JonRowe commented Apr 3, 2020

👍

@pirj pirj merged commit 0aac0c7 into master Apr 3, 2020
@pirj pirj deleted the allow-jruby-head-failures branch April 3, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants