Skip to content

Set Ruby version. #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2020
Merged

Set Ruby version. #2338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf5a907
Missing minimal Ruby version
marcandre Apr 13, 2020
a04709e
Lower target ruby version to match Rails 5
JonRowe May 16, 2020
f7437a5
Change log for #2319, #2338
JonRowe May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ AllCops:
Bundler/DuplicatedGem:
Enabled: false

Gemspec/RequiredRubyVersion:
# Rubocop checks that the target ruby version matches the gemspec version
# but doesnt have a 2.2 option
Enabled: false

Layout/AccessModifierIndentation:
Enabled: false

Expand Down
1 change: 1 addition & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Bug Fixes:
* Fix comparison of times for `#at` in job matchers. (Jon Rowe, Markus Doits, #2304)
* Allow `have_enqueued_mail` to match when a sub class of `ActionMailer::DeliveryJob`
is set using `<Class>.delivery_job=`. (Atsushi Yoshida #2305)
* Add `required_ruby_version` to gem spec. (Marc-André Lafortune, #2319, #2338)

### 4.0.0 / 2020-03-24
[Full Changelog](https://github.com/rspec/rspec-rails/compare/v3.9.1...v4.0.0)
Expand Down
1 change: 1 addition & 0 deletions rspec-rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Gem::Specification.new do |s|
s.homepage = "https://github.com/rspec/rspec-rails"
s.summary = "RSpec for Rails"
s.description = "rspec-rails is a testing framework for Rails 5+."
s.required_ruby_version = ">= 2.2.0"

s.metadata = {
'bug_tracker_uri' => 'https://github.com/rspec/rspec-rails/issues',
Expand Down