Remove Ruby version constraint workarounds #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
remove-ruby-version-constraint-workarounds
branch
from
b8253c4 to
ed6a963
Compare
|
Green! |
JonRowe
reviewed
Oct 10, 2020
We used to specify them to pin them.
|
It was a nice excursion back into time when we had 72 build jobs. |
pirj
force-pushed
the
remove-ruby-version-constraint-workarounds
branch
from
e3c020f to
29aeb00
Compare
JonRowe
approved these changes
Oct 10, 2020
|
Yes!! Thanks |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this PR is to remove workaround previously needed to work around Rubygems API not providing necessary gem Ruby constraints under certain conditions.
The problem was presumably fixed in Rubygems.
A couple of passed builds have no odd gem version resolutions resulting in Ruby version incompatibility.
Follow-up to #2380
Related to rubygems/rubygems#3463