Update docs to use the correct branch name for older rails versions #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Feb 1, 2021
README.md
Outdated
Comment on lines
34
to
39
| # Or, run against the master branch | ||
| # (requires master-branch versions of all related RSpec libraries) | ||
| # Replace branch name with the appropriate branch for your rails version | ||
| group :development, :test do | ||
| %w[rspec-core rspec-expectations rspec-mocks rspec-rails rspec-support].each do |lib| | ||
| gem lib, :git => "https://github.com/rspec/#{lib}.git", :branch => 'master' | ||
| gem lib, :git => "https://github.com/rspec/#{lib}.git", :branch => '3-9-maintenance' |
There was a problem hiding this comment.
The latest on the 3-9-maintenance branch is released and can be fetched from RubyGems with ~> 3.9 as described above.
There was a problem hiding this comment.
This isn't mentioned with the block gem declaration.
|
Thank you for your contribution, but we do not maintain the previous versions. |
|
I think updating the readme is a reasonable ask here. |
JonRowe
reviewed
Feb 2, 2021
README.md
Outdated
| @@ -33,9 +33,10 @@ Use **[`rspec-rails` 1.x][]** for Rails 2.x. | |||
|
|
|||
| # Or, run against the master branch | |||
| # (requires master-branch versions of all related RSpec libraries) | |||
| # Replace branch name with the appropriate branch for your rails version | |||
There was a problem hiding this comment.
This whole comment block should be:
# Or, run against the maintenance branch
# (requires the same maintenance branch for all related RSpec libraries)
There was a problem hiding this comment.
Additionally prehaps we should add:
# Note that 3.9 is end of life and all changes have been released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2452