Skip to content

Remove incompatible --color CLI option #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Conversation

pirj
Copy link
Member

@pirj pirj commented Sep 18, 2021

The option was removed in RSpec 4, see rspec/rspec-core#2864
Follow-up to #2458

The option was removed in RSpec 4, see rspec/rspec-core#2864
Follow-up to #2458
@pirj pirj self-assigned this Sep 18, 2021
@pirj
Copy link
Member Author

pirj commented Sep 18, 2021

Merging, as there's no external behaviour change, it only affects our builds. To my best knowledge, --color is a no-op, as color_mode is :automatic by default ("the output will be in color if the output is a TTY").

@pirj pirj merged commit 6a34d62 into main Sep 18, 2021
@pirj pirj deleted the remove-incompatible-color-flag branch September 18, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant