Add a scenario for using subdomain constrained routes #2520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Sep 27, 2021
| headers = { "ACCEPT" => "application/json" } | ||
| post "/widgets", :params => { :widget => {:name => "My Widget"} }, :headers => headers | ||
|
|
||
| expect(response.content_type).to eq("application/json; charset=utf-8") |
There was a problem hiding this comment.
As you may have noticed, content_type depends on the Rails version. We have different examples, and they are either run or skipped depending on CI job matrix.
I suggest .to start_with("application/json") so that this example passes with all Rails versions from our matrix.
There was a problem hiding this comment.
Hi @pirj ,
Thanks for your feedback. I added the requested changes.
However the test without the host! is still passing, so I wanna look into this again. I will let you know once the PR is ready for review again.
Thanks for taking the time!
There was a problem hiding this comment.
I checked on Rails 6 that this fails without host!
JonRowe
approved these changes
Oct 7, 2021
|
Thank you for the contribution! |
JonRowe
added a commit
that referenced
this pull request
Jan 26, 2022
Add a scenario for using subdomain constrained routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some documentation on how to use
host!in before block for testing subdomain constrained requests.Credits for this go to @gferrarocamus for pointing this out, see #789 (comment)