Skip to content

Fix some typos #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Bug Fixes:

Enhancements:

* Issue a warning when using job matchers with `#at` mis-match on `usec` precision.
* Issue a warning when using job matchers with `#at` mismatch on `usec` precision.
(Jon Rowe, #2350)
* Generated request specs now have a bare `_spec` suffix instead of `request_spec`.
(Eloy Espinaco, Luka Lüdicke, #2355, #2356, #2378)
Expand Down Expand Up @@ -226,7 +226,7 @@ Bug Fixes:

Bug Fixes:

* Namespaced fixtures now generate a `/` seperated path rather than an `_`.
* Namespaced fixtures now generate a `/` separated path rather than an `_`.
(@nxlith, #2077)
* Check the arity of `errors` before attempting to use it to generate the `be_valid`
error message. (Kevin Kuchta, #2096)
Expand Down Expand Up @@ -386,7 +386,7 @@ Enhancements:

Bug fixes:

* Prevent asset helpers from taking precendence over route helpers. (Prem Sichanugrist, #1496)
* Prevent asset helpers from taking precedence over route helpers. (Prem Sichanugrist, #1496)
* Prevent `NoMethodError` during failed `have_rendered` assertions on weird templates.
(Jon Rowe, #1623).

Expand Down
2 changes: 1 addition & 1 deletion benchmarks/before_block_capture_block_vs_yield.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def capture_block_and_call_n_times(n, &block)

__END__

This attemps to measure the performance of how `routes` works in RSpec. It's
This attempts to measure the performance of how `routes` works in RSpec. It's
actually a method which delegates to `before`. RSpec executes `before` hooks by
capturing the block and then performing an `instance_exec` on it later in the
example context.
Expand Down
2 changes: 1 addition & 1 deletion features/controller_specs/setting_request_headers.feature
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Feature: Setting request headers

We recommend you to switch to request specs instead of controller specs if you want to set
headers in your call. If you still want to set headers in controller specs, you can use
`request.headers` as mentioned bellow.
`request.headers` as mentioned below.

Scenario: Setting a header value in a controller spec
Given a file named "spec/controllers/application_controller_spec.rb" with:
Expand Down
2 changes: 1 addition & 1 deletion lib/rspec/rails/matchers/active_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def check_for_inprecise_value(scheduled_at)
|`Time.current.change(usec: 0)`
|
|Note: RSpec cannot do this for you because jobs can be scheduled with usec
|precision and we do not know wether it is on purpose or not.
|precision and we do not know whether it is on purpose or not.
|
|
WARNING
Expand Down
2 changes: 1 addition & 1 deletion script/functions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function run_specs_and_record_done {

function run_cukes {
if [ -d features ]; then
# force jRuby to use client mode JVM or a compilation mode thats as close as possible,
# force jRuby to use client mode JVM or a compilation mode that's as close as possible,
# idea taken from https://github.com/jruby/jruby/wiki/Improving-startup-time
#
# Note that we delay setting this until we run the cukes because we've seen
Expand Down