Skip to content

Fix a spec on Rails edge #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix a spec on Rails edge #2669

merged 1 commit into from
Apr 19, 2023

Conversation

pirj
Copy link
Member

@pirj pirj commented Apr 18, 2023

E.g. https://github.com/rspec/rspec-rails/actions/runs/4737397779/jobs/8410153979?pr=2664

expected /Title can't be blank/, got #<RSpec::Expectations::ExpectationNotMetError: expected #<Post:0x000055d41c8941d0 @validation_context=nil, @errors=#<ActiveModel::Errors [#<ActiveModel::Error attribute=title, type=blank, options={}>]>> to be valid, but got errors: Title can’t be blank>

The difference is in the typographic quote:
rails/rails@da82e58#diff-78b236371af76b069c91eedb316bb68bfe71ab6bd1850f7c5a4c9291eaa13c79R16

E.g. https://github.com/rspec/rspec-rails/actions/runs/4737397779/jobs/8410153979?pr=2664

expected /Title can't be blank/, got #<RSpec::Expectations::ExpectationNotMetError: expected #<Post:0x000055d41c8941d0 @validation_context=nil, @errors=#<ActiveModel::Errors [#<ActiveModel::Error attribute=title, type=blank, options={}>]>> to be valid, but got errors: Title can’t be blank>

The difference is in the typographic quote:
rails/rails@da82e58#diff-78b236371af76b069c91eedb316bb68bfe71ab6bd1850f7c5a4c9291eaa13c79R16
@pirj pirj self-assigned this Apr 18, 2023
@JonRowe JonRowe merged commit b94b058 into main Apr 19, 2023
@JonRowe JonRowe deleted the fix-rails-edge-failure branch April 19, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants