Skip to content

Adding values_match? in have_broadcasted_to checker to accept anything as a hash value when data is provided #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Adding values_match? in have_broadcasted_to checker to accept anything as a hash value when data is provided #2684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rspec/rails/matchers/action_cable/have_broadcasted_to.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def check(messages)
decoded = ActiveSupport::JSON.decode(msg)
decoded = decoded.with_indifferent_access if decoded.is_a?(Hash)

if @data.nil? || @data === decoded
if @data.nil? || values_match?(@data, decoded)
@block.call(decoded)
true
else
Expand Down
6 changes: 6 additions & 0 deletions spec/rspec/rails/matchers/action_cable/have_broadcasted_to_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,12 @@ def broadcast(stream, msg)
}.to have_broadcasted_to('stream').with(a_hash_including(name: "David", id: 42))
end

it "passes with provided data matchers with anything" do
expect {
broadcast('stream', id: 42, name: "David", message_id: 123)
}.to have_broadcasted_to('stream').with({ name: anything, id: anything, message_id: anything })
end

it "generates failure message when data not match" do
expect {
expect {
Expand Down