Fix support for namespaced fixtures with rspec-rails 6.1.0 and rails 7.1

[benedikt]

This pull request fixes an issue with namespaced fixtures in Rails 7.1 and RSpec Rails 6.1 as described in #2715

The problem is related to this change in fixture_support.rb.

The fixtures method is only looking at the keys of fixture sets, but I think it also needs to look at the values. The keys seem to represent the method name, and the values represent the fixture names.

It works fine for not namespaced fixtures, but the values are different for namespaced ones:

{
  "accounts"=>"accounts",
  "users"=>"users",
  "oauth2_access_tokens"=>"oauth2/access_tokens",
  "oauth2_refresh_tokens"=>"oauth2/refresh_tokens",   
  "oauth2_applications"=>"oauth2/applications",
}

Calling access_fixture with the method name raises the error described above, because the fixture cache is based on the fixture name (with / in the values).

This pull request changes the implementation to use both method_name and fixture_name.

[pirj]

Thank you!
I kindly appreciate if you find a way to prevent regression with some spec that won’t add a new doc example.

[pirj]

Even though this may be a good measure against regressions, this also serves as public-facing documentation. And this scenario doesn’t bring value as such. Do you think it would be possible to cover this differently?

[pirj]

Specs aren’t probably an option. Might be the example_app_generator or snippets (eg https://github.com/rspec/rspec-rails/blob/main/snippets/use_active_record_false.rb)?

[benedikt]

@pirj I removed the changes to the feature file for now. I'll see if I can come up with a way to test this otherwise, but I'm not familiar with the project setup so any help would be appreciated 🙂

[JonRowe]

I'm happy to merge this but it needs a regression check of some sorts, it probably needs a generated spec in the example app...

[JonRowe]

I added the required regression check and have merged this in, thank you for your work.

[benedikt]

@JonRowe Thanks for figuring out the regression tests! I'm pretty sure I wouldn't have been able to figure out the solution you landed on 👍

[JonRowe]

Released in 6.1.1