Declare an activemodel dependency

[jfirebaugh]

mocks.rb requires active_model, therefore it should be listed in the gemspec.

[fables-tales]

@jfirebaugh does this fix a particular issue that you were having?

[jfirebaugh]

Yes, konacha uses rspec-rails in tests but does not have an activemodel dependency itself, so this fixes a require error I was getting (current workaround).

[JonRowe]

The issue is that you don't have to use mock_model (which is what I assume requires ActiveModel) and you don't have to use ActiveModel in Rails so this is adding an extra unnecessary dependency which most people will already have in their own dependencies if they are using it.

[jfirebaugh]

If you want to avoid the dependency entirely, then mocks.rb needs to rescue from the failure of require "active_model" or otherwise do a conditional require. As it is there is a dependency on activemodel, it just isn't declared.

[JonRowe]

It's an optional dependency, which rubygems doesn't allow us to specify. We probably should rescue the require and issue a warning tho.

[jfirebaugh]

I'm confused. Issue a warning? rspec/rails/mocks.rb is included by rspec/rails.rb. So, if I'm not using mock_model, am I expected to manually require all the files under rspec/rails that I do use, but not rspec/rails.rb, in order to avoid the warning?

[alindeman]

Thanks @jfirebaugh. I'll include this in an upcoming 2.14.1. In the mean time you could point at the 2-14-maintenance branch.