Change some version checks to use ActiveRecord. #804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow using ActiveRecord fixtures without pulling in all of Rails.
|
Thanks! I think this looks good, but I want to see the entire test suite green. Unfortunately the autotest extraction broke the rspec-rails' test suite for a few days. It's since been fixed, so I rebased your changes and opened #805. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use ActiveRecord fixtures in my tests for a gem that uses ActiveRecord, but doesn't depend on all of Rails. Currently rspec-rails makes some checks based on
::Rails::VERSION.This change uses
::ActiveRecord::VERSIONfor those checks related to ActiveRecord fixtures, allowing fixtures to be used without including Rails.