Skip to content

Switch have support to use the extracted gem #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Sep 8, 2013

We extracted the have(n) etc matchers to a seperate gem, use that in rspec-rails 3.x

@JonRowe
Copy link
Member Author

JonRowe commented Sep 9, 2013

I've realised this clashes with @soulcutter #810

Which path do we prefer gang?

/cc @myronmarston @alindeman @samphippen

We need to merge one of them...

@myronmarston
Copy link
Member

I prefer to keep all the logic in the rspec-collection_matchers gem. If we keep this logic in rspec-rails, I think it sends a mixed message about what the preferred way of asserting on collection size is.

@JonRowe JonRowe mentioned this pull request Sep 9, 2013
@JonRowe JonRowe closed this Sep 9, 2013
@JonRowe JonRowe deleted the fix_have_matchers branch September 9, 2013 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants