Skip to content

Latest rspec-core master renamed deprecations to warnings. #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2013

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Oct 9, 2013

No description provided.

@gonzalo-bulnes
Copy link

Hello,

I was following the README_DEV to run the tests suite and getting the following error:

~/.rvm/gems/ruby-1.9.3-head@rspec-rails/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `require': cannot load such file -- rspec/core/deprecation (LoadError)

The @JonRowe patch fixed it.

@gonzalo-bulnes
Copy link

BTW, I believe the Travis build failure is not related to this patch.
The failing example (rspec ./spec/models/widget_spec.rb:9) doesn't fail everytime.

bundle exec cucumber features/model_specs/transactional_examples.feature
# sometimes reports 4 scenarios passed and 1 failed, 3 passed

Sadly the RSpec output is only shown when the example fails and I can only say the 11376, 20962, 6435 and 10265 seeds trigger the failure.
How can I make Cucumber to run RSpec in verbose mode?

I tried to modify the Cucumber When steps with no visible effects, and didn't find any other step definition for them.

# features/model_specs/transactional_examples.feature

# ...

Scenario: disable transactions (explicit)
    Given a file named "spec/models/widget_spec.rb" with:
      """ruby
      require "spec_helper"

      RSpec.configure do |c|
        c.use_transactional_examples = false
        c.order = "default"
      end

      describe Widget do
        it "has none to begin with" do
          expect(Widget.count).to eq 0
        end

        it "has one after adding one" do
          Widget.create
          expect(Widget.count).to eq 1
        end

        it "has one after one was created in a previous example" do
          expect(Widget.count).to eq 1
        end

        after(:all) { Widget.destroy_all }
      end
      """
    When I run `rspec spec/models/widget_spec.rb --format documentation`
    Then the examples should all pass

# ...

JonRowe added a commit that referenced this pull request Oct 12, 2013
Latest rspec-core master renamed deprecations to warnings.
@JonRowe JonRowe merged commit a467fa8 into master Oct 12, 2013
@JonRowe JonRowe deleted the use_warnings_file branch October 12, 2013 23:40
@JonRowe
Copy link
Member Author

JonRowe commented Oct 12, 2013

Merged because master is failing anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants